Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LegacyDatasetService
overridesgetDatasets()
such that allImageDisplays
will be lazily registered when the user callsgetDatasets()
. All other methods simply wrap a call to the next highest priorityDatasetService
.LegacyDatasetService follows the pattern used for LegacyImageDisplayService.
@ctrueden, @hinerm the code that registers the datasets is in the function
registerDatasets()
. Let me know if that look OK.My understanding is that this service will be made obsolete by #105. If that is not the case let me know. If this code has a long-term shelf life than there is a couple more things I should do (like putting similar code for
LegacyDatasetService
andLegacyImageDisplayService
in a shared utility).