Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy dataset service #127

Closed
wants to merge 2 commits into from
Closed

Legacy dataset service #127

wants to merge 2 commits into from

Conversation

bnorthan
Copy link
Contributor

LegacyDatasetService overrides getDatasets() such that all ImageDisplays will be lazily registered when the user calls getDatasets(). All other methods simply wrap a call to the next highest priority DatasetService.

LegacyDatasetService follows the pattern used for LegacyImageDisplayService.

@ctrueden, @hinerm the code that registers the datasets is in the function registerDatasets(). Let me know if that look OK.

My understanding is that this service will be made obsolete by #105. If that is not the case let me know. If this code has a long-term shelf life than there is a couple more things I should do (like putting similar code for LegacyDatasetService and LegacyImageDisplayService in a shared utility).

LegacyDatasetService overrides getDatasets() such that all ImageDisplays
will be lazily registered when the user calls getDatasets().  All other
methods simply wrap a call to the next highest priority DatasetService.
@ctrueden
Copy link
Member

Thanks for following up with this, @bnorthan. There are some tweaks I'd like to do with the patches; I'll try to work on it next week some time.

@imagejan
Copy link
Member

@ctrueden is this PR still relevant?

@ctrueden
Copy link
Member

ctrueden commented May 22, 2017

Thanks for the ping. I cannot remember. I will bookmark this to resolve some time soon, by some definition of "soon."

@ctrueden
Copy link
Member

By the definition of "soon" where it is one year and two days later: I now close this, since #182 was merged. If anyone has reason to think these changes are still necessary, please reopen and/or file another PR accordingly.

@ctrueden ctrueden closed this May 24, 2018
@ctrueden ctrueden deleted the legacy_dataset_service branch May 24, 2018 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants