-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update site with command line do not work #106
Comments
This issue has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/fiji-add-update-site-headless-do-not-work/83673/3 |
@elevans @gselzer @hinerm I forgot to mention this during the dev meeting. If you have a bit of time to see if I'm the only one experiencing the issue and potentially to see where the error comes please let me know! Because of this bug, I had to "disable" https://github.com/BIOP/biop-bash-scripts |
@NicoKiaru wrote:
Did you also test correct behavior if the update site indeed is active already? Or does that just suppress the error message? |
Good point, yeah, I do not know what to test, so thanks for jumping in. I'll give it a shot. Besides, I do not understand is how this could have worked before... |
There's potentially the line 1277 and 1249 that need to be modified:
But it does not really work in the end. After having executed:
I still need to go to the GUI and click apply: |
I wonder if sciview is affected by this, as they use the updater in headless mode for their deployment: |
Fix #106 by setting the correct update site flags in CommandLine.java
As described in the forum thread, add an update site through command line do not work anymore. The updater sends an error
[ERROR] Site 'QuickFigures' was already added!
even if the site was NOT added.I wonder if that's an unintended consequence of the new GUI for the updater.
I do not know if it's the appropriate fix, but changing:
imagej-updater/src/main/java/net/imagej/updater/CommandLine.java
Line 1276 in dd4b18a
to
final UpdateSite site = files.getUpdateSite(name, false);
fixes the issue.OS: win 11, Fiji up to date on 14th July 2023 (ImageJ 2.14.0/1.5f Java 1.8.0_322 64 bits)
The text was updated successfully, but these errors were encountered: