Add deletion check to test #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frauzufall
added a commit
to imagej/imagej-plugins-uploader-webdav
that referenced
this pull request
Feb 8, 2019
* depends on imagej/imagej-updater#73 * by checking if a file is actually deleted, AbstractUploaderTestBase.test() will now fail for HTTPS (because uploading does not work there yet) * removes unused import
frauzufall
added a commit
to juglab/imagej-plugins-uploader-webdav
that referenced
this pull request
Feb 11, 2019
* adds test if deleted files really don't exist anymore afterwards * adds boolean isDeleted(String path) function to Deleter interface * other Uploaders must implement this method, otherwise NotImplementedException is thrown when running this test
frauzufall
force-pushed
the
fix-upload-test
branch
from
ee32efc
to
2aec07f
Compare
|
This happened here: 41bc3f9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current test for uploading is pretending things are working when they are not.
The current webdav uploader has a reflection hack overriding the default GET method of a HTTP request by special ones like
DELETEorOPTIONS. For HTTPS, this hack does not work. Therefore, when assuming the DELETE method is called, the GET method is called instead. In case the file is present, it returns200- all good. The test is assuming deleting worked and continues..This PR adds a test if deleted files really don't exist anymore afterwards. It also adds a
boolean isDeleted(String path)function to Deleter interface. Other Uploaders must implement this method, otherwiseNotImplementedExceptionis thrown when running this test. The Exception is the reason why I added thecommons-langdependency..Not happy with the naming of
isUpdateSiteEmpty()either since the test is only checking if thedb.xml.gzis present.. But since it's a public method I was not sure about renaming it.