Mayday #101
Closed
Mayday #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rasband I fixed the conflicts and whitespace errors, so the "Files changed" tab shows a much cleaner patch now. @dprodanov Could you please comment on your intent here? Just tightening up the typing? @rasband If you are OK with parameterizing types in this way, it could be done in many more places... what do you think? |
|
I do not see the need to parameterize types in this way. |
|
Hi Wayne,
Type parametrization is already accepted practice in Java for more than 10
years.
Why do you insist on the legacy coding practices?
best regards,
Dimiter
…On Tue, May 19, 2020 at 4:34 AM rasband ***@***.***> wrote:
I do not see the need to parameterize types in this way.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#101 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANM2OLUIRXP3CAGOOEBB5LRSHV2BANCNFSM4NDK7REA>
.
|
|
These changes are in the latest daily build (1.53b21). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test generic parametrization of Overlay.java