Bump Maximum Python version to 3.11 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.62% // Head: 90.65% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
+ Coverage 90.62% 90.65% +0.02%
==========================================
Files 44 44
Lines 4087 4099 +12
==========================================
+ Hits 3704 3716 +12
Misses 383 383
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Some names (i.e. "in") are valid in Python, but are invalid in Java. We add a py_name function onto ModuleItem to translate those "invalid" names
gselzer
force-pushed
the
bump-python-3-11
branch
from
4e773ff
to
cbd6db4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While napari is still working on 3.11 support (see napari/napari#5439), a default napari-imagej conda install will install Python 3.11☹️
Fortunately, all the tests pass, so we can probably just bump the CI job to run on 3.11 and be fine. Unfortunately, I'm running into a parameter naming issue, described in #166. So we should probably fix that here.