HowTo improvements #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frauzufall
force-pushed
the
howto-improvements
branch
from
f188e52
to
ee6cc40
Compare
|
Merging this before it gets too stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the reviews of #77.
Two mentioned improvements I did not include:
NewImageCommand without GUI since it's aDynamicCommand. I tried to set the dynamically created dimension parameters like this:ij.command().run(NewImage.class, true, "X", 50l, "Y", 70l);but no luck.imglib2-roifor drawing. It's so cryptic. Before this is merged the currently used strategies look easier in my opinion.