Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK enhancements #20

Merged
merged 16 commits into from
Jun 11, 2024
Merged

SDK enhancements #20

merged 16 commits into from
Jun 11, 2024

Conversation

AniVerma17
Copy link
Collaborator

  • Add following features in the SDK:
    • URL constructor methods for adaptive video streaming, adding raw transform options as a string, and image loading in the responsive manner according to the target view.
    • Upload policy to set constraints on upload requests for device conditions, retry mechanism etc.
    • Upload preprocessors to transform images and video before uploading.
  • Migrate the uploader methods and API calls to the V2 upload API.
  • Remove the deprecated overlay transformation options from URL constructor.

Also resolves #9.

@AniVerma17
New methods and changes in URL constructor (#12)
90b9e05 
* REMOVE: deprecated overlay transform methods and classes

* ADD: URL constructor methods for raw params, responsive image transforms and adaptive video streaming

* REMOVE: SDK version string and deprecated overlay params mappings

* FIX: stream format extension in constructed streaming URL

* FIX: argument error message in responsive URL method
@AniVerma17
Migration to V2 upload API (#13)
d216830 
* REMOVE: upload signature API call from uploader methods

* ADD: missing upload data parameters

* ADD: API call for upload auth token in sample app

* FIX: null parameters issue in uploader methods
@AniVerma17
Upload policy (#14)
71ac573 
* ADD: classes and enums for upload policy

* ADD: default upload policy in SDK initializer

* ADD: retry mechanism for upload API calls

* ADD: function to check network and battery status as per the upload policy

* FIX: upload method calls and upload policy checks

* FIX: visibilty modifiers of internal classes and enums

* FIX: battery state monitoring for upload policy check

* ADD: upload policy param to image upload call in sample app
@AniVerma17
Upload preprocessors (#15)
1e59b48 
* ADD: base protocols for upload preprocessors

* ADD: image upload preprocessor

* ADD: video upload preprocessor
@AniVerma17
Update unit tests (#16)
66be40b 
* ADD: unit tests

* FIX: errors in image processors

* FIX: upload preprocessors' members visibilty

* FIX: unit tests for image preprocessors
@AniVerma17
Update SDK and deployment version (#17)
dea80a3 
* ADD: unit tests

* FIX: errors in image processors

* FIX: upload preprocessors' members visibilty

* FIX: unit tests for image preprocessors

* CHANGE: pod version and iOS deployment target version
@AniVerma17
Fix pod lint and unit tests (#18)
d3b1021 
* ADD: unit tests

* FIX: errors in image processors

* FIX: upload preprocessors' members visibilty

* FIX: unit tests for image preprocessors

* CHANGE: pod version and iOS deployment target version

* FIX: unit tests and pod lint failures
@AniVerma17
Update unit tests for uploads (#19)
0778a9c 
* ADD: unit tests

* FIX: errors in image processors

* FIX: upload preprocessors' members visibilty

* FIX: unit tests for image preprocessors

* CHANGE: pod version and iOS deployment target version

* FIX: unit tests and pod lint failures

* ADD: request body checks in unit tests for uploads
@AniVerma17
Bump minimum iOS version for deployment (#21)
0193c77 
* ADD: unit tests

* FIX: errors in image processors

* FIX: upload preprocessors' members visibilty

* FIX: unit tests for image preprocessors

* CHANGE: pod version and iOS deployment target version

* FIX: unit tests and pod lint failures

* ADD: request body checks in unit tests for uploads

* ADD: unit tests for retry timeout
ahnv
ahnv requested changes Jan 18, 2024
View reviewed changes
ImageKit/ImageKitUploader.swift Outdated Show resolved Hide resolved
ImageKit/Util/UploadApi.swift Outdated Show resolved Hide resolved
ImageKit/ImageKit.swift Show resolved Hide resolved
@AniVerma17
Add logging for upload failures (#22)
dacbb6a 
* REMOVE: unused import statement

* ADD: log statements for upload failures and retry attempts
ahnv
ahnv requested changes Feb 5, 2024
View reviewed changes
Example/ImageKit/FetchImageViewController.swift Outdated Show resolved Hide resolved
Example/ImageKit/FetchImageViewController.swift Outdated Show resolved Hide resolved
Example/ImageKit/FetchImageViewController.swift Outdated Show resolved Hide resolved
Tests/Tests.swift Outdated Show resolved Hide resolved
@wtsnz
Copy link

wtsnz commented Feb 16, 2024

Hey, I've been using the latest version and have noticed the the ability to subscribe to progress updates via the uploadProgressHandler doesn't work. Progress is never reported on media uploads. I was curious if this is 1) a known issue, and 2) if so, planned to be fixed.

@imagekitio
Copy link
Collaborator

@ahnv are we okay in using v2 version of upload API?

@ahnv
Copy link
Member

ahnv commented Jun 3, 2024

@ahnv are we okay in using v2 version of upload API?

I have added the v2 dummy server, we should be good to provide the functionality

@AniVerma17
ADD: constants for sample app (#24)
1715de5
@AniVerma17
Fix constants in sample auth service (#25)
0360a1f 
* ADD: constants for sample app

* CHANGE: replace public key constant in the auth payload
@ahnv ahnv mentioned this pull request Jun 11, 2024
Open
@ahnv ahnv merged commit 2870683 into master Jun 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahnv ahnv ahnv approved these changes

@imagekitio imagekitio Awaiting requested review from imagekitio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fatal error: Public Key / Authentication Endpoint is not defined while initalizing the SDK
4 participants
@AniVerma17 @wtsnz @imagekitio @ahnv