Update node versions #34
Conversation
|
+1 since this will also update the dependencies, it will remove this warning: Since The history goes like this:
So yeah, please consider merging this PR to upgrade ^-^ |
|
Pinging @sindresorhus in the hope he can merge it..... |
|
/cc @sindresorhus we have a lot of warning and security report from |
|
@sindresorhus, any reason this hasn't been merged? |
|
I can think of no reason except maybe that he and the other maintainers dont care about this library enough anymore and have other things to do i assume. but I am happy if they prove me wrong.... |
|
+1 @rejas now I use your fork, please don't remove branch |
|
@noveogroup-amorgunov I dont think that you should rely on my branch, rather fork mine yourself and use that. Then you can be 100% sure it wont get deleted :-) |
|
oh there's also @bradbaris and @1000ch who can merge it since they're part of the organisation |
| - '6' | ||
| - '4' | ||
| - '8' | ||
| - '10' |
There was a problem hiding this comment.
Why did you change sort order? If you don't have special meaning, please fix them along with before.
| - nodejs_version: '6' | ||
| - nodejs_version: '4' | ||
| - nodejs_version: '8' | ||
| - nodejs_version: '10' |
Removed outdated node4, add new node10 Also update appveyor.yml Removed outdated node4, add new node10 Update dependencies Update engines entry to node6 Update dependencies Fix order
|
Done. |
|
Yay, we did it! 🎉 That fix was pretty fast 👍 |
|
@Pizzacus I only celebrate when a new release is published and release on npm :-) |
|
True true, but at least we can use the GitHub directly in the dependancies without having to fork your fork and all |
|
@1000ch Thx for merging. Will there be a new release on npm in the foreseeable future? |
|
@rejas We also have to resolve downloaded files' mode problem before publishing. Waiting to merge this PR or fix. |
|
thx for the info @1000ch hopefully that PR gets merged soon. |
|
So, the PR got merged, can we get a new relase now please here @1000ch ? |
|
Thx. Alas, the accompaning mozjpeg lib hasnt seen a release since imagemin/mozjpeg-bin#41 was merged. Can this be done too? |
|
Also released mozjpeg v6.0.1 to remove gulp-util warning on install. |
node 4 shouldnt be supported, but node10