Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several tweaks #61

Merged
merged 1 commit into from Jul 28, 2023
Merged

Several tweaks #61

merged 1 commit into from Jul 28, 2023
+16 −16

Conversation

1000ch
Copy link
Member

@1000ch 1000ch commented Jul 22, 2023

No description provided.

@1000ch 1000ch merged commit f7dfc71 into main Jul 28, 2023
18 checks passed
@1000ch 1000ch deleted the nodejs-20 branch July 28, 2023 03:55
@gmetais
Copy link

gmetais commented Sep 2, 2023 •
edited

Hi @1000ch,

Thank you for updating the dependencies!
It would be awesome if you could update the package's version and publish it on NPM to allow us to use it.

@gmetais
Copy link

gmetais commented Sep 2, 2023

Wait... It might actually not be a good idea. I detect a breaking change if I provide a Buffer instead of a String.

TypeError: Expected a `string`, got `object`
at isSvg (./node_modules/is-svg/index.js:4:11)
  ./node_modules/imagemin-svgo/index.js:9:8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@1000ch @gmetais