Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES2015ify and require Node.js 4 #14

Merged
merged 1 commit into from Mar 31, 2017
Merged

ES2015ify and require Node.js 4 #14

merged 1 commit into from Mar 31, 2017

Conversation

1000ch
Copy link
Member

@1000ch 1000ch commented Mar 25, 2017

@1000ch 1000ch force-pushed the es2015ify branch 3 times, most recently from 37e41b3 to e0b6e76 Compare March 28, 2017 16:20
@1000ch 1000ch merged commit 687a34e into master Mar 31, 2017
@1000ch 1000ch deleted the es2015ify branch March 31, 2017 04:20
- '0.12'
- '0.10'
- 6
- 4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These needs to be quoted. Versions are strings, not numbers.

@@ -7,7 +7,7 @@ skip_tags: true

environment:
matrix:
- nodejs_version: '0.12'
- nodejs_version: 4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Needs to be quoted.

1000ch pushed a commit that referenced this pull request Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants