Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adsk Contrib - Add minor & major version to the configuration #589

Conversation

hodoulp
Copy link
Member

@hodoulp hodoulp commented Oct 1, 2018

During the Working Group at SIGGRAPH, we agreed to have a major+minor version scheme.
The change adds the major and minor versions to the config class, plus some unit tests.

@hodoulp
Copy link
Member Author

hodoulp commented Oct 1, 2018

Failure on the pdf generation because the target is missing (even if all the previous builds succeeded):

0.01s$ if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then cmake --build . --target pdf; fi
make: *** No rule to make target `pdf'.  Stop.
The command "if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then cmake --build . --target pdf; fi" exited with 2.

Note: Restart the build fixed the problem.

@scoopxyz scoopxyz merged commit 7822163 into AcademySoftwareFoundation:master Oct 8, 2018
scoopxyz pushed a commit to scoopxyz/OpenColorIO that referenced this pull request Jun 4, 2019
@hodoulp hodoulp deleted the adsk_contrib/add_versions branch June 25, 2019 03:42
fnordware pushed a commit to fnordware/OpenColorIO that referenced this pull request Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants