Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved Pipelines include path to hammurabi #63

Closed
luizfelippesr opened this issue Oct 6, 2020 · 2 comments · Fixed by #62
Closed

Saved Pipelines include path to hammurabi #63

luizfelippesr opened this issue Oct 6, 2020 · 2 comments · Fixed by #62
Labels
bug Something isn't working infrastructure Installation, optimization, internal (re)organization Pipeline Involves Pipeline objects

Comments

@luizfelippesr
Copy link
Member

When a saved pipeline is loaded, the Hammurabi simulator keeps the absolute path to hamx binary, as observed by @trjaffe in #60 (comment)

As we support Hammurabi as part of IMAGINE, this the save_pipeline should be instructed to check the path to hamx, and adjust it when loading.
@luizfelippesr luizfelippesr added infrastructure Installation, optimization, internal (re)organization Pipeline Involves Pipeline objects Simulator Involves Simulator objects bug Something isn't working and removed Simulator Involves Simulator objects labels Oct 6, 2020
@luizfelippesr luizfelippesr mentioned this issue Oct 7, 2020
Merged
3 tasks
@luizfelippesr luizfelippesr linked a pull request Oct 7, 2020 that will close this issue
Observables plotting tools #62
Merged
3 tasks
@luizfelippesr
Copy link
Member Author

A similar issue is the path to the xml template, which is also system dependent.

luizfelippesr added a commit that referenced this issue Oct 7, 2020
@luizfelippesr
Resolves issue #63
12b2e0d 
If a Pipeline has Hammurabi as simulator, and this uses the default path for hamx executable (set using the `hammurabi_hamx_path` rc variable), once saved and reloaded the Pipeline will adjust to use the default path in the new system.
@luizfelippesr
Copy link
Member Author

luizfelippesr commented Oct 7, 2020 •
edited
Loading

@trjaffe could you please check whether you still have problems running tutorial_wmap.ipynb on the obs_dict_plots branch?

For this to work, the default path to hammurabi must be set either through the rc['hammurabi_hamx_path'] variable or setting IMAGINE_HAMMURABI_HAMX_PATH environment variable (before importing imagine, see here for details).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working infrastructure Installation, optimization, internal (re)organization Pipeline Involves Pipeline objects
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Observables plotting tools IMAGINE-Consortium/imagine
1 participant
@luizfelippesr