You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While it's common practice to accept Sequence[T] when a function can accept a list, tuple, etc., it's often best to be more specific with return types allowing those invoking the methods to have greater clarity of the type returned. In many of DICOMwebClient's methods, current type hints provide a return value of Sequence[T] where List[T] would be more specific. I propose updating these types to the more specific values provided the API is comfortable committing to these types (which seems like a fairly innocuous commitment).
The text was updated successfully, but these errors were encountered:
While it's common practice to accept
Sequence[T]
when a function can accept a list, tuple, etc., it's often best to be more specific with return types allowing those invoking the methods to have greater clarity of the type returned. In many ofDICOMwebClient
's methods, current type hints provide a return value ofSequence[T]
whereList[T]
would be more specific. I propose updating these types to the more specific values provided the API is comfortable committing to these types (which seems like a fairly innocuous commitment).The text was updated successfully, but these errors were encountered: