Remove hard dependency of json=2.6.2 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current version of `keycloak` depended on `json=2.6.2` that can cause issues especially on ruby ~>3.2 which have json=2.6.3 as it's default json gem. If the user activate any gem that require "json", on ruby `3.2.2` -> json version `2.6.3` will be activated. And if this happens before `keycloak` was loaded you will get activation exception after loading `keycloak`: `Unable to activate keycloak-3.2.2, because json-2.6.3 conflicts with json (= 2.6.2) (Gem::ConflictError)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version of
keycloakdepended onjson=2.6.2that can cause issues especially on ruby ~>3.2 which have json=2.6.3 as it's default json gem. If the user activate any gem that require "json", on ruby3.2.2-> json version2.6.3will be activated. And if this happens beforekeycloakwas loaded you will get activation exception after loadingkeycloak:Unable to activate keycloak-3.2.2, because json-2.6.3 conflicts with json (= 2.6.2) (Gem::ConflictError)