Allowing http redirects.

[SolRosenberg]

Request for change to provide option for allowing Imagr instances to follow redirects. Redirect option similar to munki would suffice (although I myself only require an all redirects scenario).

Tested as working on Imagr build 0.0.5 by changing line 276 in Utils.py to:

headers = get_url(url, temp_file, follow_redirects=True, additional_headers=additional_headers)

Graham mentioned the possibility of issues with ASR and/or hdiutil so if this is to be implemented this should be tested heavily. I only require this for Imagr's initial grabbing of the imagr_config.plist file. My testing does not go beyond Imagr grabbing the imagr_config file i.e. I am not running workflows whose payloads are grabbed via redirected URLs.

[grahamgilbert]

I'm pretty sure ASR and hdiutil won't work with redirects - they're both pretty basic. But assuming were talking only the initial config plist, I would say we would need to:

• Expose this as a preference with the default being OFF
• Have the option to restrict redirects to only valid HTTPS URLs if desired (much the same as I did for Munki)

This isn't going to make the 1.0 release (because that's happening now), but I will take pull requests for it. It's on my list, but since I don't need this, other things are higher.

[SolRosenberg]

Can we have a help wanted label added to this?