-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goto Extension: CountNested #58
Comments
@TakeruWolf Finding some time to work on this now. You're right, it's good to have both. |
@TakeruWolf Think you could give the copy of deck.goto.js on the master branch a try? It just uses the same countNested option, so you shouldn't need to set it in two places. If everything looks as good to you as it does to me I'll move to stable and update docs. |
Works fine for me without changing any code just by pulling the commit. Also works in edge conditions. Seems perfect to me :) Thanks! |
…d total but in legal range of actual slide count
Cool, I found a new case where if the slide total was above the countNested total, but below the full total, it would fall back to going to that index. It should do nothing, and the commit above fixes that. Moving this into stable now. |
It would be very comfortable if the goto extension would provide a CountNested option as the status extension does.
I'm using deck.js for powerpoint-like presentations (it's awesome!) and the audience is seeing "page x/y", where x != the internal slide number if I'm using CountNested. If someone says "please show me page x again", I can't just use the goto extension and type in x. I must know the internal number of x which is uncomfortable.
The text was updated successfully, but these errors were encountered: