Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

Update README.md #5

Merged
merged 3 commits into from
Oct 12, 2019
Merged

Update README.md #5

merged 3 commits into from
Oct 12, 2019

Conversation

usamahjundia
Copy link
Contributor

@usamahjundia usamahjundia commented Oct 12, 2019

Added the description for the feature in issue #1 . Is there any significance of reporting the last time a path was removed from history that i can add?

@imambungo
Copy link
Owner

Yeah, you can add something like "This may help you decide the history size that suits you"
with "history size" is a link to #um-only-10.

@usamahjundia
Copy link
Contributor Author

I have updated the description to also hint the user that it may help adjusting the history size, and refer to the link mentioned above.

README.md Outdated
@@ -18,6 +18,7 @@ that still saved after exiting the terminal. A directory is considered to be use

- Automatically list all files in the directory you jumped to if it contains 30 or fewer files. You can [disable this feature](#dont-list-files-after-jump) if you like.
- Home or `~/` is never added to the history (we can just type `cd`).
- Shows the last time a path was removed from the history. This information may help you adjust the history size to better suit your need. To change the history size, refer to [this section](https://github.com/imambungo/dirjump/blob/master/dirjump#um-only-10)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Shows the last time a path was removed from the history. This information may help you adjust the history size to better suit your need. To change the history size, refer to [this section](https://github.com/imambungo/dirjump/blob/master/dirjump#um-only-10)
- Shows the last time a path was removed from the history. This information may help you adjust the history size to better suit your need. To change the history size, refer to [this section](#um-only-10)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to specify the URL or path if we refer to the file itself.

@usamahjundia
Copy link
Contributor Author

I have updated the readme file.

Copy link
Owner

@imambungo imambungo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 👍

@imambungo imambungo merged commit f6c29f9 into imambungo:master Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants