Ensure ruby uses top-level WebSocket constant in client.rb. Provides em-websocket compatibility. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables compatibility with the em-websocket server gem. The em-websocket gem adds a WebSocket module under the EventMachine namespace. The client.rb file references the WebSocket constant while executing within the EventMachine namespace. Once em-websocket is required, client.rb begins using the WebSocket module provided by the em-websocket gem instead of the correct top-level constant that it expects, resulting in undefined method exceptions.
imanel
added a commit
that referenced
this pull request
Dec 26, 2012
Ensure ruby uses top-level WebSocket constant in client.rb. Provides em-websocket compatibility.
|
Thanks - released as version 1.0.1 bugfix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables compatibility with the em-websocket server gem.
The em-websocket gem adds a WebSocket module under the EventMachine
namespace. The client.rb file references the WebSocket constant while
executing within the EventMachine namespace. Once em-websocket is
required, client.rb begins using the WebSocket module provided by
the em-websocket gem instead of the correct top-level constant that
it expects, resulting in undefined method exceptions.