Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make media clickable #39

Closed
4 tasks done
imashnake0 opened this issue Jul 3, 2022 · 0 comments 路 Fixed by #40
Closed
4 tasks done

Make media clickable #39

imashnake0 opened this issue Jul 3, 2022 · 0 comments 路 Fixed by #40
Labels
enhancement Enhancement feature New feature

Comments

@imashnake0
Copy link
Owner

imashnake0 commented Jul 3, 2022

Being able to click on media is, I feel like, the next most natural addition. This helps build a foundation for navigation
(consider: Continued use of navigation-compose or simple-stack 馃憖; decided to use compose-destinations) and heavier requests, which means we'd likely have to use a shimmer or something else to indicate a load. We should also ideally have mockups for this page.

  • Modify MediaQuery.
  • Create mockups.
  • Improve navigation and make media clickable.
  • Integrate with Search bar聽#23.
@imashnake0 imashnake0 added enhancement Enhancement feature New feature labels Jul 3, 2022
@imashnake0 imashnake0 added this to In progress in Animite Jul 3, 2022
@imashnake0 imashnake0 linked a pull request Jul 7, 2022 that will close this issue
1 task
@imashnake0 imashnake0 mentioned this issue Aug 7, 2022
Closed
4 tasks
@imashnake0 imashnake0 moved this from In progress to In review in Animite Sep 8, 2022
@imashnake0 imashnake0 moved this from In review to Done in Animite Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement feature New feature
Projects
Animite
  
Done
Milestones
Awaiting triage
Development

Successfully merging a pull request may close this issue.

1 participant