New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media Page #40
Merged
Merged
Media Page #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The media stuff was only used to test the API initially, this will be modified and implemented for the media page(s).
Closed
4 tasks
Directly copied over some potential fields.
Changed some parameter names to support manga lists.
Toasted "bro".
This toasts the media's id!
This toasts the media's metadata.
Reject Toasting, return to logging.
Added extension to prettify data class strings.
:dev_oreo_hmm:
Just added logging capability, if you tap on any of the media (here, anime), some metadata is logged, e.g.,
|
Since I'd have to work on the Figma mock-up next, I might put this on hold until after my finals. Wish me luck! 🤞 |
Created files for the Media page.
Reviewed release notes and updated Compose and a couple other libraries.
REEEEEEEEEEEEEEEE
We need to hide the navigation bar somehow.
Needed to hide the navigation bar on the `MediaPage`.
Forgot to include this.
Redundant but whatever.
Everything on top of the tabs.
Longer cross-fade between `Home` and `MediaPage`; le slide between `Home` and `Profile`.
Fixed the weird default crossfade flash.
Might make reusable components since we need something similar for the characters list :hmm:.
This works now.
I think it looks better like this?
Added a... row for characters.
Need to work on the intent.
The done.
Compose destinations mfw.
It is done!
Made it transparent since the bottom of the search bar is sometimes under the keyboard.
This fixes nested navigation but double clicking launches two of the same screen (since `launchSingleTop = false`).
Maybe I should add a divider to make the items' separation more apparent. :hmm:
Added TODOs and completed review.
imashnake0
commented
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md
.Adds a Media page and other small improvements to the Home page.
Summary of changes:
MediaQuery
.MediaPage
.MediaPage
.SearchBar
.Tested changes:
Works fine.