Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Higher quality thumbnails #117

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Higher quality thumbnails #117

merged 4 commits into from
Jan 9, 2024

Conversation

imashnake0
Copy link
Owner

Replaced default thumbnails with maxresdefault and added two more fall backs.

Summary of changes:

  1. Fallbacks: maxresdefault -> sddefault -> Default thumbnail from API.

Tested changes:

  • maxresdefault is on most entries.
  • "Haikyuu!!" for sddefault.
  • "Highschool of the Dead" for the default thumbnail.

@imashnake0 imashnake0 added the enhancement Enhancement label Jan 8, 2024
Made fallbacks conditional so they don't always happen.
@uragiristereo
Copy link
Collaborator

comment

Co-Authored-By: Agung Watanabe <52477630+uragiristereo@users.noreply.github.com>
Copy link
Collaborator

@uragiristereo uragiristereo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@imashnake0 imashnake0 merged commit 4dd5f8c into main Jan 9, 2024
1 check passed
@imashnake0 imashnake0 deleted the thumbnail branch January 9, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants