Cleanup HomeScreen and MediaPage
#123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imashnake0
changed the title
Home and MediaPageHomeScreen and MediaPage
boswelja
reviewed
Feb 3, 2024
app/src/main/java/com/imashnake/animite/features/media/MediaPage.kt
Outdated
Show resolved
Hide resolved
Closed
4 tasks
boswelja
reviewed
Feb 3, 2024
app/src/main/java/com/imashnake/animite/features/home/HomeViewModel.kt
Outdated
Show resolved
Hide resolved
boswelja
reviewed
Feb 4, 2024
| @@ -76,12 +78,15 @@ fun Home( | |||
| val upcomingList by viewModel.upcomingMediaNextSeason.collectAsState() | |||
| val allTimePopularList by viewModel.allTimePopular.collectAsState() | |||
|
|
|||
| // TODO: [Code Smells: If Statements](https://dzone.com/articles/code-smells-if-statements). | |||
| val rows = listOf( | |||
| trendingList, | |||
There was a problem hiding this comment.
I think I preferred "string" to trendingList 😔
boswelja
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md.We need to cleanup
HomeandMediaPagesince they haven't been touched in ages and because we need to create aBannerLayoutforProfileScreen.Summary of changes:
HomeScreenandMediaPage.Tested changes: