Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DI & NetworkSource Dispatchers #61

Merged
merged 3 commits into from Nov 11, 2022

Conversation

Iannnr
Copy link
Contributor

@Iannnr Iannnr commented Nov 9, 2022

Summary of changes:

Fix DI & NetworkSource Dispatchers

  • Provide ApolloClient properly via Hilt
  • Set the dispatcher in the ApolloBuilder rather than per call
  • Split up DI modules

Tested changes:

  • No observed regressions with network calls

Iannnr and others added 3 commits November 9, 2022 19:07
* Provide ApolloClient properly via Hilt
* Set the dispatcher in the ApolloBuilder rather than per call
* Split up DI modules
We might have a `retrofitClient` in the near future :hmm:
@imashnake0 imashnake0 merged commit f3fbc06 into imashnake0:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants