Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statefe doesn't handle address on the envelope peering3.c #247

Closed
miniway opened this issue Sep 26, 2012 · 1 comment
Closed

statefe doesn't handle address on the envelope peering3.c #247

miniway opened this issue Sep 26, 2012 · 1 comment

Comments

@miniway
Copy link
Contributor

miniway commented Sep 26, 2012

capacity is sent to statebe with the address

        if (local_capacity != previous) {
            //  We stick our own address onto the envelope
            zstr_sendm (statebe, self);
            //  Broadcast new capacity
            zstr_sendf (statebe, "%d", local_capacity);
        }

But statefe doesn't handle the address.

        if (primary [2].revents & ZMQ_POLLIN) {
            char *status = zstr_recv (statefe);
            cloud_capacity = atoi (status);
            free (status);
        }

peering3 works because atoi on the address returns 0. However, it doesn't look like a intention.

@hintjens
Copy link
Contributor

Thanks. Would you make a pull request with a fix?
On Sep 26, 2012 11:55 AM, "Dongmin Yu" notifications@github.com wrote:

capacity is sent to statebe with the address

    if (local_capacity != previous) {
        //  We stick our own address onto the envelope
        zstr_sendm (statebe, self);
        //  Broadcast new capacity
        zstr_sendf (statebe, "%d", local_capacity);
    }

But statefe doesn't handle the address.

    if (primary [2].revents & ZMQ_POLLIN) {
        char *status = zstr_recv (statefe);
        cloud_capacity = atoi (status);
        free (status);
    }

peering3 works because atoi on the address returns 0. However, it doesn't
look like a intention.


Reply to this email directly or view it on GitHubhttps://github.com//issues/247.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants