-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect exception when passing stream that does not expose a buffer #58
Comments
To repro and fix this I need the stream class you're using.
…On Mon, Apr 8, 2024, 8:11 AM Marcin ***@***.***> wrote:
When passing a MemoryStream that does not expose buffer via this method:
https://learn.microsoft.com/en-us/dotnet/api/system.io.memorystream.trygetbuffer?view=net-8.0
I get the following exception:
System.OverflowException:
at Imageflow.Fluent.BufferedStreamSource.TryGetWrittenMemory (Imageflow.Net, Version=0.13.1.0, Culture=neutral, PublicKeyToken=null)
at Imageflow.Fluent.BufferedStreamSource+<BorrowReadOnlyMemoryAsync>d__8.MoveNext (Imageflow.Net, Version=0.13.1.0, Culture=neutral, PublicKeyToken=null)
[snip]
, Message: Streams cannot exceed 2GB
When running code:
var memorySource = BufferedStreamSource.BorrowEntireStream(sanitizedStream);
var info = await ImageJob.GetImageInfoAsync(memorySource, SourceLifetime.Borrowed);
I think this should be validated when creating BufferedStreamSource and
more appropriate exception be thrown.
—
Reply to this email directly, view it on GitHub
<#58>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA2LH53LOZPZEYNPJTC5FTY4KQR3AVCNFSM6AAAAABF4ZNXQGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZTCMZTGM2DENQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
It is a MemoryStream created by https://learn.microsoft.com/en-us/dotnet/api/system.net.http.httpcontent.readasstreamasync?view=net-8.0 |
Thanks. This should be fixed in the next release, and will "just work" - it is supposed to fall back to using read methods |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When passing a MemoryStream that does not expose buffer via this method: https://learn.microsoft.com/en-us/dotnet/api/system.io.memorystream.trygetbuffer?view=net-8.0 I get the following exception:
When running code:
I think this should be validated when creating BufferedStreamSource and more appropriate exception be thrown.
The text was updated successfully, but these errors were encountered: