Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add incremental adoption guide and clean up other guides #255

Merged
merged 7 commits into from
Oct 11, 2022
Merged

add incremental adoption guide and clean up other guides #255

merged 7 commits into from
Oct 11, 2022

Conversation

familyfriendlymikey
Copy link
Member

@familyfriendlymikey familyfriendlymikey commented Sep 30, 2022

@familyfriendlymikey familyfriendlymikey marked this pull request as draft October 1, 2022 02:08
Copy link
Contributor

@haikyuu haikyuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, npm link section should be removed imo since it doesn't work "in practice".

Interop is a bit more than including a tag. Communicating back and forth with the other framework is a natural question to ask after including the imba tag.

Great start here. This is a much needed section in the docs 💯

content/guides/incremental.md Outdated Show resolved Hide resolved
content/guides/incremental.md Show resolved Hide resolved
content/guides/incremental.md Show resolved Hide resolved
@familyfriendlymikey
Copy link
Member Author

Thanks for taking the time to review and make suggestions earlier by the way Abdellah, really appreciate it.

@familyfriendlymikey
Copy link
Member Author

I would like to make sure these are accurate?

imba is automatically defined on the globalThis object whenever an Imba tag is registered. So as long as you import an Imba file that contains a tag, globalThis.imba will be defined.

as long as an Imba file containing tags gets imported, its custom elements will be registered.

@familyfriendlymikey familyfriendlymikey marked this pull request as ready for review October 10, 2022 08:30
@familyfriendlymikey
Copy link
Member Author

@haikyuu this should be good to go after imba/imba#746, I think it would be good to get it in before ViteConf.

Copy link
Contributor

@haikyuu haikyuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@familyfriendlymikey familyfriendlymikey merged commit afa4547 into imba:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants