Ensure set = (number) is truly a number

Closes gh-53
imbcmdth · Feb 18, 2012 · bda4621 · bda4621
1 parent 852afd3
commit bda4621
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/tags/set.js b/lib/tags/set.js
@@ -15,7 +15,7 @@ module.exports = function (indent, parentBlock, parser) {
     }
 
     value = thisArgs[0];
-    if ((/^\'|^\"|^\{|^\[/).test(value) || value === 'true' || value === 'false') {
+    if (helpers.isLiteral(value) || (/^\{|^\[/).test(value) || value === 'true' || value === 'false') {
         return ' ' + varname + ' = ' + value + ';';
     }
 

diff --git a/lib/tags/set.test.js b/lib/tags/set.test.js
@@ -34,5 +34,11 @@ exports.set = testCase({
         swig.compile('{% block a %}{{ foo }}{% endblock %}', { filename: 'a' });
         test.strictEqual(swig.compile('{% extends "a" %}{% set foo = "bar" %}')(), 'bar');
         test.done();
+    },
+
+    'set number is really a number [gh-53]': function (test) {
+        test.strictEqual(swig.compile('{% set foo = 1 %}{{ foo|add(1) }}')(), '2', 'literal number is a number');
+        test.strictEqual(swig.compile('{% set foo = "1" %}{{ foo|add(1) }}')(), '11', 'string number is not a number');
+        test.done();
     }
 });