Losing metadata when updating with invalid data

[christeredvartsen]

In the Imbo\Database\Doctrine database adapter it is possible to lose existing metadata attached to an image if the new metadata has an invalid key when updating. This is because the adapter deletes existing metadata before normalizing the incoming metadata:

// Delete existing metadata
$this->deleteMetadata($user, $imageIdentifier);

// Normalize metadata
$normalizedMetadata = $this->normalizeMetadata($metadata);

$this->normalizeMetadata($metadata); can end up throwing an exception if any metadata keys contains the namespace separator, resulting in all metadata attached to the image is deleted. If we swap the order of the lines the issue should be resolved.