Merge pull request #384 from imbs-hl/fix_solaris

fix solaris CRAN issue
imbs-hl · Jan 24, 2019 · 82b7b24 · 82b7b24
2 parents 5e31baf + cc887f0
commit 82b7b24
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 4 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,8 +1,8 @@
 Package: ranger
 Type: Package
 Title: A Fast Implementation of Random Forests
-Version: 0.11.0
-Date: 2019-01-16
+Version: 0.11.1
+Date: 2019-01-24
 Author: Marvin N. Wright [aut, cre], Stefan Wager [ctb], Philipp Probst [ctb]
 Maintainer: Marvin N. Wright <cran@wrig.de>
 Description: A fast implementation of Random Forests, particularly suited for high

diff --git a/NEWS b/NEWS
@@ -1,3 +1,6 @@
+##### Version 0.11.1
+* Bug fixes
+
 ##### Version 0.11.0
 * Add max.depth parameter to limit tree depth
 * Add inbag argument for manual selection of observations in trees

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,6 @@
+##### Version 0.11.1
+* Bug fixes
+
 ##### Version 0.11.0
 * New CRAN version
 

diff --git a/cpp_version/src/version.h b/cpp_version/src/version.h
@@ -1,3 +1,3 @@
 #ifndef RANGER_VERSION
-#define RANGER_VERSION "0.11.0"
+#define RANGER_VERSION "0.11.1"
 #endif
diff --git a/src/Data.cpp b/src/Data.cpp
@@ -170,7 +170,7 @@ void Data::getAllValues(std::vector<double>& all_values, std::vector<size_t>& sa
 
 void Data::getMinMaxValues(double& min, double&max, std::vector<size_t>& sampleIDs, size_t varID, size_t start, size_t end) const {
   if (sampleIDs.size() > 0) {
-    min = get(sampleIDs[0], varID);
+    min = get(sampleIDs[start], varID);
     max = min;
   }
   for (size_t pos = start; pos < end; ++pos) {

diff --git a/tests/testthat/test_jackknife.R b/tests/testthat/test_jackknife.R
@@ -2,6 +2,7 @@
 
 library(ranger)
 library(survival)
+library(methods)
 context("ranger_jackknife")
 
 test_that("jackknife standard error prediction working for regression", {

diff --git a/tests/testthat/test_sparse.R b/tests/testthat/test_sparse.R
@@ -1,6 +1,7 @@
 library(ranger)
 library(survival)
 library(Matrix)
+library(methods)
 context("ranger_sparse")
 
 ## Iris sparse data