Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbiased impurity importance #217

Merged
merged 34 commits into from
Sep 25, 2017
Merged

Unbiased impurity importance #217

merged 34 commits into from
Sep 25, 2017

Conversation

mnwright
Copy link
Member

No description provided.

Marvin Wright and others added 30 commits February 23, 2017 10:36
add unbiased gini importance option (not implemented yet)
65732b1
unbiased impurity working with x permuted for classification
59cd336
add TODOs
e00bedb
fix real varID selection in getAllValues()
f6706b8
fix and cleanup x permute
4151acb
move is ordered variable to data
31a7e88
use non-permuted vars for prediction
eb69d74
fix importance test
f52aada
cleanup
5d23053
check splitweights importance combination
836ef24
update version
87d0654
include missing algorithm
c989468
size_t instead of int
6b1a5b4
Merge branch 'master' into unbiased_impurity_permute_x
635dc82
new version for survival impurity importance
20cbf32
add tests for survival impurity importance
5b10973
Allow survival impurity importance in C++ versio
2f8d32d
add survival impurity importance
5b9bb11
Allow survival impurity importance in R
75b8a02
add test for survival importance p-values
0fac069
merge with new master
61face9
Fix getAllValues for survival
2948c21
add error if no covariates
0b0c5d6
rename new impurity importance to impurity_corrected
5c44191
add a warning if predicting with corrected importance forest
a7e7ead
merge new master
870fda6
fix importance pvalues for survival
656835e
Merge branch 'master' into unbiased_impurity_importance
dda1609
@mnwright
merge with new master
e8e8b9f
@mnwright
fix survival imp test
d923e61
@coveralls
Copy link

coveralls commented Sep 25, 2017 •
edited

Coverage Status

Coverage increased (+0.1%) to 94.411% when pulling a623956 on unbiased_impurity_importance into 6b5541b on master.

@coveralls
Copy link

coveralls commented Sep 25, 2017 •
edited

Coverage Status

Coverage increased (+0.2%) to 94.459% when pulling 831c201 on unbiased_impurity_importance into 6b5541b on master.

@mnwright mnwright merged commit 25ee990 into master Sep 25, 2017
@mnwright mnwright deleted the unbiased_impurity_importance branch November 22, 2017 07:35
mnwright added a commit to rcannood/ranger that referenced this pull request Oct 23, 2019
@mnwright
Merge pull request imbs-hl#217 from imbs-hl/unbiased_impurity_importance
2d451de 
Unbiased impurity importance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mnwright @coveralls