Magic Trackpad 2 too sensitive (1mm from surface)

[tyger]

Pre-report checks

• Have you checked (use search) Azure DevOps Board and Github issues for known bugs and plans?

Describe the bug
Trackpad reacts on my finger that is in 1-2mm distance from trackpad surface. So basically I can move cursor not touching trackpad at all. Feels like it's too much sensitive (no such behaviour with this trackpad when connected to MacBook)

To Reproduce
Steps to reproduce the behavior:

1. Connect device to Windows laptop and intall driver
2. Try to move finger within 1-2mm from surface.

Expected behavior
Trackpad should react on the finger only and when it is touching surface of trackpad.

Traces
If applicable, add WPP traces to help explain your problem.
????

Environment
Apple Magic Trackpad 2 (Model A1535)
connected to USB to Lenovo X1 Extreme
Windows 10 v1903

driver type is USB type (User-mode)

AB#680

[imbushuo]

Currently the threshold is hard-coded, a tool for the adjustment is planned.

Also relate to #239.

[tyger]

@imbushuo What is your idea about making it adjustable?
Will it be easier to just put something into Windows Registry? That should save some time creating tools.

[imbushuo]

Have thought of that. Probably need to do some application work.

[larryqiann]

It looks like there is a sensitivity setting under Windows settings app. Could this perhaps be used to set these settings?

[reznikartem]

+1 for this issue. Mayby, because of that i often get cursor "shake"

Here is short video with demostration: https://puu.sh/EY0jZ/2f1166eb5a.mp4

[tyger]

@larryqiann

It looks like there is a sensitivity setting under Windows settings app. Could this perhaps be used to set these settings?

I don't think it's the same as settings on Windows level influence all touchpads in the system (and I'm using laptop, so have an extra one that is build in)
It must be something on the device level.

[tyger]

@reznikartem

+1 for this issue. Mayby, because of that i often get cursor "shake"

Here is short video with demostration: https://puu.sh/EY0jZ/2f1166eb5a.mp4

Yes, that looks like something that I experience some time as well.

[evi0s]

Same issue. Any idea about changing the threshold? Maybe we can modify the source code and compile it manually before the tools release.

[taterujp]

I also have the exactly same issue. Changing the sensitivity value in Windows setting did not affect this issue at all. Any other solutions?

[taterujp]

I also tried the Magic Utilities then the sensitivity was ok with it. However some important behavior are not supported (dragging by tap-hold-move, dragging by 1stfingerclick-2ndfingertapholdmove, horizontal scroll on Excel and other apps, etc) and it isn’t enough for me to use.
Again, is there any way to change this sensitivity?

[omegamalkior]

I also tried the Magic Utilities then the sensitivity was ok with it. However some important behavior are not supported (dragging by tap-hold-move, dragging by 1stfingerclick-2ndfingertapholdmove, horizontal scroll on Excel and other apps, etc) and it isn’t enough for me to use.
Again, is there any way to change this sensitivity?

It seems to only happen with this specific precision driver. If you disconnect from it and use it with the native bluetooth or native USB support without the driver this issue does not happen. With touchpad++ driver and with the other paid driver it does not happen. Only with the Precision driver does it specifically happen. Makes it a bit unstable overall for daily use. Hopefully a fix isn't that far away.

[joeholley]

Yes, as Evi0s mentioned above, since this has gone a long time without a fix, maybe you could let us know which line has the value so we could adjust/recompile manually for the time being?

[michaelgosling]

Would love a fix for this as well. Coming up on a year with no fix now. The driver is fantastic in every other way but this hyper sensitivity can be frustrating.

[funky-jojo]

@imbushuo Any updates or timeline for providing a way to adjust the threshold? This is still a major issue, and prevents me from using it or promoting this driver to others. For me it's overly sensitive, and the cursor moves easily without even physically touching the surface.

[duckyb]

Yes, as Evi0s mentioned above, since this has gone a long time without a fix, maybe you could let us know which line has the value so we could adjust/recompile manually for the time being?

mac-precision-touchpad/src/AmtPtpHidFilter/include/Metadata/MagicTrackpad2.h

Line 8 in 734b084

USAGE, 0x47, /* Usage: Confidence */ \

mac-precision-touchpad/src/AmtPtpHidFilter/include/Metadata/MagicTrackpad2.h

Line 49 in 734b084

USAGE, 0x47, /* Usage: Confidence */ \

It's probably these two lines that affect it. Good luck if you try to compile it!

[imbushuo]

@duckyb Not really that line, there was two hardcoded threshold things in HID Input.c:

Check how tip switch bit and confidence bit is reported, and currently it's hardcoded. On high level I just need to make these two values configurable.

[funky-jojo]

Check how tip switch bit and confidence bit is reported, and currently it's hardcoded. On high level I just need to make these two values configurable.

@imbushuo Please do!!! I would definitely donate to this effort. I would pay good money for a version of this driver if usable on day-to-day basis.

[duckyb]

@imbushuo Thank you for the correction, so it's this one?

mac-precision-touchpad/src/AmtPtpHidFilter/Input.c

Lines 214 to 217 in dd364d6

	// The Microsoft spec says reject any input larger than 25mm. This is not ideal
	// for Magic Trackpad 2 - so we raised the threshold a bit higher.
	// Or maybe I used the wrong unit? IDK
	ptpOutputReport.Contacts[i].Confidence = ((signed short) (f_type5->TouchMinor) << 1) < 345 && ((signed short) (f_type5->TouchMinor) << 1) < 345;

@funky-jojo I'd love to help but I don't have the required skills to do this, unfortunately. I've never programmed in C or made drivers before.

[imbushuo]

@duckyb Yes.

[b0undl3ss]

To anyone interested - I just submitted a PR that I believe would fix this issue:

#436

I tested it out and it works perfectly, at least on my Magic Trackpad 2. Building it is a bit of a pain so hopefully we can get an official release here soon. 🤞

[mmikeww]

bump

[fhardillah]

bump

[philipwindeyer]

bump