Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md with punctuation #787

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Conversation

baishakhi9931
Copy link
Contributor

No description provided.

Copy link
Collaborator

@dlemstra dlemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request. Could you also add the other change that I suggested?

README.md Outdated
- Accepts the syntax for searchPattern on [Directory.EnumerateFiles()](https://docs.microsoft.com/en-us/dotnet/api/system.io.directory.enumeratefiles)
- Limits the images optimized by Imgbot by essentially ignoring them
- When ignoring by filename no path is necessary, when ignoring by foldername full path from root is necessary
- When ignoring by filename no path is necessary, when ignoring by folder name full path from root is necessary
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably change filename to file name also.

@Prakhar998
Copy link

make space between searchPattern to search Pattern
Accepts the syntax for searchPattern on Directory.EnumerateFiles()
Limits the images optimized by Imgbot by essentially ignoring them

@dlemstra dlemstra merged commit 3fd2c3a into imgbot:master Nov 20, 2020
@dlemstra
Copy link
Collaborator

Thanks for your additional changes @baishakhi9931.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants