Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser Support for Safari 8 #31

Closed
zaknafain opened this issue Jul 5, 2016 · 4 comments
Closed

Browser Support for Safari 8 #31

zaknafain opened this issue Jul 5, 2016 · 4 comments

Comments

@zaknafain
Copy link

zaknafain commented Jul 5, 2016 •
edited

I have some issues with Safari 8. I found out, that Safari 8 will not support this.imgEl.style.transform = 'translate(${left}px, ${top}px)';. I fixed it with the corresponding this.imgEl.style.webkitTransform = 'translate(${left}px, ${top}px)';.

Also the zoomed pane is not removed after onHide. I haven't found the solution for this though.

Are you interested in support for Safari 8?
@paulstraw
Copy link
Member

Hey @zaknafain, thanks for the report. I'll take a look at this!

paulstraw added a commit that referenced this issue Jul 12, 2016
@paulstraw
Merge pull request #32 from imgix/31-safari-8-support
674aa74 
Safari 8 support! Closes #31
@paulstraw
Copy link
Member

This is all set, and released as 0.3.1. Thanks again!

@zaknafain
Copy link
Author

Thank you! Updated - Tested - Deployed - Tested again. Working nicely.

@paulstraw
Copy link
Member

Nice. 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulstraw @zaknafain