Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add includeLibraryParam setter #32

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Add includeLibraryParam setter #32

merged 1 commit into from
Mar 13, 2018

Conversation

davidrapson
Copy link
Contributor

Adds a setIncludeLibraryParam setter method in the same style as the other constructor options. Without it it's required to pass through all arguments to the constructor which is not ideal without named parameters.

Before:

$builder = new UrlBuilder(
    'some-imgx-domain.example.com',
    true,
    "",
    ShardStrategy::CRC,
    false
);

After:

$builder = new UrlBuilder('some-imgx-domain.example.com');
$builder->setUseHttps(true);
$builder->setIncludeLibraryParam(false);

@davidrapson
Copy link
Contributor Author

Just noticed there's already a PR open for this #16

That one was opened back in March 2017 so let me know if I should close this one, or allow this to supersede the previous one.

@jayeb jayeb merged commit b2483eb into imgix:master Mar 13, 2018
@jayeb
Copy link
Contributor

jayeb commented Mar 13, 2018

Thanks @davidrapson! This is out in version 2.1.0 now.

@davidrapson davidrapson deleted the include-library-param-setter branch March 13, 2018 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants