Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create custom srcsets #58

Merged
merged 3 commits into from
May 29, 2020
Merged

Conversation

ericdeansanchez
Copy link
Contributor

@ericdeansanchez ericdeansanchez commented May 22, 2020

The purpose of this PR is to refactor and normalize the custom
srcset creation interface.

@ericdeansanchez ericdeansanchez changed the title feat: create custom srcsets [WIP] feat: create custom srcsets May 22, 2020
Copy link
Contributor

@sherwinski sherwinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think that maybe there was some mix up with two of the test cases:

tests/Imgix/Tests/UrlBuilderTest.php Outdated Show resolved Hide resolved
tests/Imgix/Tests/UrlBuilderTest.php Outdated Show resolved Hide resolved
@ericdeansanchez ericdeansanchez merged commit ec5f2ba into master May 29, 2020
@ericdeansanchez ericdeansanchez deleted the refactor-custom-srcsets branch May 29, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants