refactor: change tolerance from int -> float #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherwinski
approved these changes
May 29, 2020
ericdeansanchez
changed the title
ericdeansanchez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, width
tolerance was expected to be of typeintand within the range of
[1, 100]or "one to one hundred percent."Now,
tolis expected to be afloatin the range[0.01, 1.0]whichalso represents "one to one hundred percent."
We have done this for consistency purposes, i.e. imgix-core-js uses
floating point values. Since
imgix-core-jswas impl'd first, we deferto this tried/tested interface. This way, this feature is standard
and consistent kit-wide.