Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include dpr parameter when generating fixed-width srcset #50

Merged
merged 5 commits into from Sep 4, 2019
Merged

fix: include dpr parameter when generating fixed-width srcset #50

merged 5 commits into from Sep 4, 2019

Conversation

sherwinski
Copy link
Contributor

This PR adds a few things that were missed in #48, namely:

  • including the dpr parameter when generating a DPR srcset
  • mentioning the use of fit=crop in documentation
  • more test cases for DPR srcsets
  • performance refactoring

jayeb
jayeb approved these changes Sep 3, 2019
View reviewed changes
Copy link

@jayeb jayeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nitpicks, but otherwise this looks good.

tests/test_srcset.py Outdated Show resolved Hide resolved
tests/test_srcset.py Show resolved Hide resolved
@sherwinski sherwinski merged commit 6af3a08 into master Sep 4, 2019
@sherwinski sherwinski deleted the srcset-part-2 branch September 4, 2019 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayeb jayeb jayeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sherwinski @jayeb