Imgix Client Purge Method #37
Conversation
Implement basic token authentication api.imgix.com/v2/image/purger request using net:http and web mock for test suite
There was a problem hiding this comment.
Thanks for the PR, @tyrauber. Purge support is something we've been talking about adding to this library (and all of our core libraries) for a long time, but haven't had the time to do it just yet.
There's a couple of specific problems with the implementation at the moment, which I've noted in comments below. Happy to discuss any of these further if you have questions.
I also have a feature request that I'd like you to add if possible--we currently track how often our libraries are used via the ixlib parameter, which we append to all URLs generated by each library unless the user turns the feature off. We'd like to do the same thing here, but with the user-agent header. Can you modify the code to add User-Agent: imgix rb-VERSION to each purge request?
- use @api_token in purge request - remove full url option - add ixlib parameter to purge requests - update purge_test.rb and README
|
@jayeb Sorry for jumping the roadmap. Unfortunately, purge support is something we require in production ASAP. When I saw the curl purge example, I thought I might as well take the extra hour and fork and update the gem. This last commit should resolve the outstanding concerns, but let me know. FYI - I added the user agent as requested - |
- remove ability to disable library tracking - test should test user-agent - update README content
|
Of course, @jayeb, Glad to help. Let me know if you need anything else. |
| @@ -20,4 +20,6 @@ Gem::Specification.new do |spec| | |||
|
|
|||
| spec.required_ruby_version = '>= 1.9.0' | |||
| spec.add_dependency 'addressable' | |||
| spec.add_dependency 'http' | |||
There was a problem hiding this comment.
sorry if I'm being dense, but is this gem actually being used here? AFAIK, it uses an HTTP class, and this PR only uses Net::HTTP, not HTTP. It'd be great to not require it if we don't really need it!
There was a problem hiding this comment.
@benhutton You are absolutely correct. Addressed in #38. Thanks for catching that.
Implement basic token authentication api.imgix.com/v2/image/purger request using net:http and web mock for test suite