Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip over tags that fail validations #175

Merged
merged 3 commits into from
Nov 26, 2019
Merged

Conversation

sherwinski
Copy link
Contributor

This PR addresses two issues that can result in broken tags:

  • Current validations do not catch instances of ix-src="" or ix-path="", which can cause errors further down the line
  • Throwing any error on failed validations will halt imgix.js from processing subsequent img or picture tags, even if they are valid. This PR circumvents this scenario by only processing an image if all validations are passed.

src/ImgixTag.js Outdated Show resolved Hide resolved
src/ImgixTag.js Outdated Show resolved Hide resolved
@sherwinski sherwinski merged commit a996feb into master Nov 26, 2019
@sherwinski sherwinski deleted the fix-empty-str-validate branch November 26, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants