Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme is out of sync with latest npm version #35

Closed
mitchellbutler opened this issue Aug 8, 2018 · 2 comments
Closed

Readme is out of sync with latest npm version #35

mitchellbutler opened this issue Aug 8, 2018 · 2 comments

Comments

@mitchellbutler
Copy link

Based on the readme the host setting is deprecated in favour of the domains setting. The latest version of this package on npm will throw an error if the host is not provided. Ideally changes like this, including to the readme, would be made in feature branches and pulled into master as part of a release to avoid confusion.
@hashknot
Copy link
Contributor

hashknot commented Aug 9, 2018

Hi @mitchellbutler,

I am sorry about the confusion. I just released v1.2.0. In the future, we'll make sure the GitHub repository and the NPM package is up-to-date.

Feel free to close the issue if v1.2.0 is working fine for you.

@mitchellbutler
Copy link
Author

Just updated to the latest version and confirmed it's working. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mitchellbutler @hashknot