Update js-md5 to v0.4 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running in a certain server runtimes v0.3.0 makes the assertion that the `navigator` option is available on the global scope resulting in the error `Cannot read property 'navigator' of undefined`. This appears to be fixed in v0.4
NGMarmaduke
force-pushed
the
update-js-md5
branch
from
ccd4b60
to
fe06892
Compare
|
Thanks @NGMarmaduke! This has been released as 1.0.4. |
|
🎉 This PR is included in version 0.3.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in a certain server runtimes v0.3.0 makes the assertion
that the
navigatoroption is available on the global scope resultingin the error
Cannot read property 'navigator' of undefined.This appears to be fixed in v0.4.
The offending line can be found here: https://github.com/emn178/js-md5/blob/v0.3.0/src/md5.js#L20