Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove "v" prefix from VERSION constant #289

Merged
merged 1 commit into from
Jun 7, 2021
Merged

fix: remove "v" prefix from VERSION constant #289

merged 1 commit into from
Jun 7, 2021

Conversation

sherwinski
Copy link
Contributor

The inclusion of the prefix (e.g. ixlib=js-v3.1.3) causes issues in our internal reporting that result in versions of this libray with the prefix to not be correctly captured. This commit removes the prefix to match the format previous to the current major version.

The inclusion of the prefix (e.g. `ixlib=js-v3.1.3`) causes issues in
our internal reporting that result in versions of this libray with the
prefix to not be correctly captured. This commit removes the prefix to
match the format previous to the current major version.
@sherwinski sherwinski requested a review from a team June 4, 2021 22:22
@commit-lint
Copy link

commit-lint bot commented Jun 4, 2021

Bug Fixes

  • remove "v" prefix from VERSION constant (60d8666)

Contributors

sherwinski

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@sherwinski sherwinski changed the title fix: remove "v" prefix from VERSION constant fix: remove "v" prefix from VERSION constant Jun 4, 2021
Copy link
Contributor

@frederickfogerty frederickfogerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants