Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing types to _buildSrcSet type declaration #299

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

luqven
Copy link
Contributor

@luqven luqven commented Jul 22, 2021

Adds the following missing types to types/index.d.ts

// * @param {Object} srcsetModifiers - srcset modifiers, optional
// * @param {Object} clientOptions - imgix client options, optional

So that _buildSrcSet types are defined as

  static _buildSrcSet(
    path: string,
    params?: {},
    srcSetOptions?: {},
    clientOptions?: {},
  ): string;

@luqven luqven self-assigned this Jul 22, 2021
@luqven luqven requested a review from a team as a code owner July 22, 2021 14:40
@commit-lint
Copy link

commit-lint bot commented Jul 22, 2021

Bug Fixes

  • add missing types to _buildSrcSet (2ea35f7)

Contributors

luqven

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

Copy link
Contributor

@frederickfogerty frederickfogerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luqven luqven merged commit b0806cf into next Jul 22, 2021
@luqven luqven deleted the luis/addSrcSetOpts branch July 22, 2021 17:52
@imgix-git-robot
Copy link
Collaborator

🎉 This PR is included in version 3.3.1-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants