fix: prevent overwriting htmlAttributes.ref #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaredloson Feel free to take a look and leave feedback as well. |
sherwinski
commented
Nov 13, 2019
frederickfogerty
suggested changes
Nov 13, 2019
frederickfogerty
approved these changes
Nov 14, 2019
There was a problem hiding this comment.
Thanks for making those changes @sherwinski! I'd be happy to merge it in this state, but I think there's just a few little things we could improve if we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #494
Refactoring work completed in #475 inadvertently introduced a regression where we are overwriting a
refpassed viahtmlAttributes. This PR better handles this situation while accounting for refs that are either passed as a callback or an object.