feat: add type attribute and fallback widths #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Apr 8, 2022
sherwinski
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
LGTM, just a couple of questions
- I noticed that you removed the dist folder completely. Was this intentional or do you want to add it back in at a later point, ie first stable release?
- Looks like we gutted most of the helper functions. Was that because there was actually no need for them? Just wanted to get some clarity there.
Comment on lines
+1
to
8
| export const generateUid = function () { | ||
| let ID = ''; | ||
| const characters = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789'; | ||
| for (let i = 0; i < 12; i++) { | ||
| ID += characters.charAt(Math.floor(Math.random() * 36)); | ||
| } | ||
| return ID; | ||
| }; |
There was a problem hiding this comment.
Where do we intend on using this?
There was a problem hiding this comment.
|
sherwinski
reviewed
Apr 11, 2022
| * This removes the shadow root and renders the elements as children of the | ||
| * host element. | ||
| * | ||
| * This in turn removes our ability to use `css` and `cssPart` |
There was a problem hiding this comment.
Just checking but does this somehow affect the decorator on L10 of this file?
There was a problem hiding this comment.
Ah, yes. That's a JS doc but probably not needed now.
sherwinski
reviewed
Apr 11, 2022
Comment on lines
+143
to
+144
| * The options set here will override any options set in the dataSetup | ||
| * attribute. |
There was a problem hiding this comment.
Might be worth calling out that video.js will automatically merge these together for us?
luqven
force-pushed
the
l/delete-unused-files
branch
from
bf0925b
to
aa447cc
Compare
This commit refactors `ix-video.ts` so that: 1. Less JSON parsing/object manipulation needs to be done to use dataSetup. 2. Fallback styling is more in line with user expectations and videojs defaults 3. There are no FOUC issues when using fallback styling 4. Since shadow-dom is off, we defensively add unique identifiers to video players One of the main changes in this commit is the use of the `connectedCallback()` lifecycle method to set a minimum width for the host component and the video element. Another significant change is the use of the `type` attribute. Although it defaults to HLS, adding it allows us to provide a way for users to use this component with other video filetypes
The css-part jsdoc tells the web-component manifest parser that the shadow dom exposes that css "part". We're not using the shadow dom so we should not include it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR:
After this PR
Steps to test
To test in React, Vite
npm/yarn linknpm/yarn buildnpm/yarn link @imgix/shared-wcTo test locally
npm run devornpm run serveix-video.ts