Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure freetype feature works via crates.io package #596

Closed
dbr opened this issue Jan 5, 2022 · 0 comments · Fixed by #597
Closed

Ensure freetype feature works via crates.io package #596

dbr opened this issue Jan 5, 2022 · 0 comments · Fixed by #597
Assignees
@dbr

Comments

@dbr
Copy link
Contributor

dbr commented Jan 5, 2022

Same problem fixed in #595 most likely applies to the main branch (although maybe the glob patterns are broken, and instead it just ends up including everything? Either way needs fixed up)

Ideally we'd test installing via the crate package in CI to catch similar problems in future
@dbr dbr self-assigned this Jan 5, 2022
dbr added a commit to dbr/imgui-rs that referenced this issue Jan 5, 2022
@dbr
Fix up glob patterns in imgui-sys
9128066 
Were set based on old pre-docking-branch-support paths

Closes imgui-rs#596
@dbr dbr mentioned this issue Jan 5, 2022
Merged
@dbr dbr closed this as completed in #597 Jan 17, 2022
ctrlcctrlv pushed a commit to MFEK/imgui.rlib that referenced this issue Sep 24, 2022
@dbr @ctrlcctrlv
Fix up glob patterns in imgui-sys
092bf88 
Were set based on old pre-docking-branch-support paths

Closes imgui-rs#596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbr dbr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix up glob patterns in imgui-sys dbr/imgui-rs
1 participant
@dbr