Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore ImFontConfig contructor #88

Closed
o01eg opened this issue Nov 16, 2017 · 2 comments
Closed

Restore ImFontConfig contructor #88

o01eg opened this issue Nov 16, 2017 · 2 comments

Comments

@o01eg
Copy link
Contributor

o01eg commented Nov 16, 2017

cimgui 1.52.1 restored accidentally removed in previous versions default constructor for ImFontConfig: cimgui/cimgui#43

@o01eg
Copy link
Contributor Author

o01eg commented Dec 24, 2017

Is it going to be restored or there another way to create ImFontConfig?

@o01eg o01eg mentioned this issue Jan 10, 2018
malikolivier added a commit to malikolivier/imgui-rs that referenced this issue Apr 29, 2018
Update cimgui, fixing imgui-rs#97 and imgui-rs#88.

As a side note, the previous version has some compiler warning showing
up during build:

warning: third-party/cimgui/imgui/imgui.cpp: In function ‘void ImGui::RenderTriangle(ImVec2, ImGuiDir, float)’:
warning: third-party/cimgui/imgui/imgui.cpp:3136:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
warning:          r = -r; // ...fall through, no break!
warning:          ~~^~~~

The new version has no warning.
malikolivier added a commit to malikolivier/imgui-rs that referenced this issue Apr 29, 2018
Update cimgui, fixing imgui-rs#97 and imgui-rs#88.

As a side note, the previous version has some compiler warning showing
up during build:

warning: third-party/cimgui/imgui/imgui.cpp: In function ‘void ImGui::RenderTriangle(ImVec2, ImGuiDir, float)’:
warning: third-party/cimgui/imgui/imgui.cpp:3136:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
warning:          r = -r; // ...fall through, no break!
warning:          ~~^~~~

The new version has no warning.
@malikolivier
Copy link
Collaborator

@Gekkio I think this issue can be closed. ImFontConfig_DefaultConstructor was added back in #119 .

@Gekkio Gekkio closed this as completed May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants