inline calls to key_index into methods which operate on keys #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make them easier to call for the user closes imgui-rs#415
thomcc
approved these changes
Dec 31, 2020
|
This entire MR is incorrect. For one, the keys_down array is 512 long, whereas the key_map is only 22 long. Forcing the key_conversion index means you can't actually use any of the key_down parts of the code anymore. |
|
I think it's fair to state that this probably inadvertently harmed some use cases (use cases involing keys that imgui doesn't use). You should still be able to access it via That said, it's probably worth adding back functions to call the ImGUI functions without going through the key map. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if someone needs to call
key_indexso maybe this should still remain pub but I could not see an obvious reason (and also not specific reason for the casts but don't have a strong opinion about it either).closes #415