Support winit-0.26 #583
Merged
Support winit-0.26 #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks -- I need to release a patch anyway. I'll try to get that done on Sunday night |
|
Great, thanks! |
|
We should update these places too: |
|
Along with the additions Thom mentions - if the version number is left untouched it'd make it easier to merge in, then we can cherry-pick the change into the branch referenced in #581 (which includes my attempts at backporting the text-input bugfixs) |
cwfitzgerald
force-pushed
the
winit-0.26
branch
from
8ef33b9
to
f6401e3
Compare
|
All three things changed! |
|
going to merge this in once it goes green |
|
thanks @cwfitzgerald ! |
|
We should remember to move from 0.25-by-default to 0.26-by-default on the next semver-major change of imgui-winit-support |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds winit 0.26 support to imgui-winit-support as non-default. This is a non-breaking change and I've tested all versions of winit with the crate.
I have bumped the version number, as it would be greatly appreciated a patch version could be released. This is currently the last blocking piece of updating my project to winit 0.26.