Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with a more up-to-date code sample #630

Closed
wants to merge 1 commit into from

Conversation

Jasper-Bekkers
Copy link
Collaborator

No description provided.

@dbr
Copy link
Contributor

dbr commented Mar 20, 2022

Hmm, I think the current example is correct - the general approach (mentioned in the 0.9 tracking issue) is that everything gets built by methods on imgui::Ui

So imgui::Window::new is deprecated, and ui.window("Hello World") is the way :

#[deprecated(since = "0.9.0", note = "use ui.window(...) instead")]
pub fn new(ui: &'ui Ui, name: Label) -> Self {

@dbr dbr closed this Mar 20, 2022
@Jasper-Bekkers
Copy link
Collaborator Author

I see - makes sense why it doesn't work with the latest stable release then ;-)

@dbr
Copy link
Contributor

dbr commented Mar 21, 2022

Ahhh, right! Yes the readme and examples will be a little confusing until the next release 😬 Need to make sure to view them via the previous tag, https://github.com/imgui-rs/imgui-rs/tree/v0.8.2

@dbr dbr deleted the Jasper-Bekkers-patch-1 branch November 30, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants